carl-mastrangelo commented on issue #27700:
URL: https://github.com/apache/beam/issues/27700#issuecomment-1654589941

   >  What functionality are you use for beam-sdks-java-extensions-sql-jdbc ?
   
   
   It may be the incorrect jar to use, but I need to write the result of my 
HTTP calls to a database.  In effect, GET a resource and then save it to a DB.  
 
   
   
   > I see, its because beam-sdks-java-extensions-sql-jdbc is a fat" jar 
(having all dependency shaded)
   
   It is a fat jar, but I don't believe it is shaded.   I think that would help 
though.  (If it were shaded, the packages would look more like 
`org.apache.beam.vendored.okio. BufferedSink`).    However, any one who was 
accidentally depending on this jar would also fail at runtime with a 
NoClassDefError if the class was shaded.   Personally, I think shading would be 
the reasonable choice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to