Abacn commented on code in PR #27721:
URL: https://github.com/apache/beam/pull/27721#discussion_r1277617682
##########
build.gradle.kts:
##########
@@ -241,16 +241,12 @@ tasks.register("javaPreCommit") {
dependsOn(":runners:core-java:build")
dependsOn(":runners:direct-java:build")
dependsOn(":runners:extensions-java:metrics:build")
- dependsOn(":runners:flink:1.12:build")
- dependsOn(":runners:flink:1.12:job-server:build")
- dependsOn(":runners:flink:1.13:build")
- dependsOn(":runners:flink:1.13:job-server:build")
- dependsOn(":runners:flink:1.14:build")
- dependsOn(":runners:flink:1.14:job-server:build")
- dependsOn(":runners:flink:1.15:build")
- dependsOn(":runners:flink:1.15:job-server:build")
- dependsOn(":runners:flink:1.16:build")
- dependsOn(":runners:flink:1.16:job-server:build")
+ // lowest and highest supported flink versions
+ var flinkVersions = project.ext.get("allFlinkVersions") as Array<*>
+ dependsOn(":runners:flink:${flinkVersions[0]}:build")
+ dependsOn(":runners:flink:${flinkVersions[0]}:job-server:build")
+ dependsOn(":runners:flink:${flinkVersions[flinkVersions.size - 1]}:build")
+ dependsOn(":runners:flink:${flinkVersions[flinkVersions.size -
1]}:job-server:build")
Review Comment:
> How often are we aware of catching a java issue with flink specific tests?
I do not remember a specific example, but I imagine this could happen in
general.
We may still need at least one exercised in the main test suite, for the
purpose of code coverage stat.
Similar practice is done in Spark runner precommit. In main test suite it
runs with Spark 3.2; there is an Spark3_Version Precommit run additonal
versions:
https://github.com/apache/beam/blob/a4f29348ff7eadf8e0330e28815fdc30a53e0f0e/runners/spark/3/build.gradle#L35
(btw I should name the test suite "job_PreCommit_Java_Flink_Versions" in
alignment with Spark version)
Will make the main precommit suite run only one flink version, and rename
the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
