piotr-szuberski commented on pull request #12325: URL: https://github.com/apache/beam/pull/12325#issuecomment-668469132
@ihji @chamikaramj ping > Thanks, looks good to me overall. > > Is there any way to share the pipeline codes in `CrossLanguageKafkaIOTest` and `CrossLanguageKafkaIO`? Could we share the pipeline codes and use `max_num_records` only in `CrossLanguageKafkaIOTest`? The internal test only checks `sum_counter` so you could keep any value in the `PCollection` afterward and assert it. It required a small modification (triggers don't work with bounded source - max_num_records changes unbounded to bounded) and sum_counter returns [None], so I use just ReadFromKafka and skip the rest of the read pipeline. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
