robertwb commented on code in PR #27536:
URL: https://github.com/apache/beam/pull/27536#discussion_r1277804285
##########
sdks/python/apache_beam/runners/worker/operations.py:
##########
@@ -1124,16 +1118,17 @@ def encode_progress(value):
remaining = current_element_progress.fraction_remaining
assert completed is not None
assert remaining is not None
+ progressCoder = coders.IterableCoder(coders.FloatCoder())
completed_mi = metrics_pb2.MonitoringInfo(
urn=monitoring_infos.WORK_COMPLETED_URN,
type=monitoring_infos.PROGRESS_TYPE,
labels=monitoring_infos.create_labels(ptransform=transform_id),
- payload=encode_progress(completed))
+ payload=progressCoder.encode([completed]))
Review Comment:
snake_case not camelCase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
