robertwb commented on code in PR #27284:
URL: https://github.com/apache/beam/pull/27284#discussion_r1280863071
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -415,6 +415,10 @@ def _parse_window_spec(spec):
'Flatten': Flatten,
'WindowInto': WindowInto,
'GroupByKey': beam.GroupByKey,
+ 'SumPerKey': lambda: beam.CombinePerKey(sum),
Review Comment:
Given everything is put into the global namespace, I think we should be
judicious. Note that TopNLargest is just CombineGlobally(TopN).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
