damccorm commented on code in PR #27758:
URL: https://github.com/apache/beam/pull/27758#discussion_r1281304700
##########
.github/workflows/beam_PreCommit_Go.yml:
##########
@@ -37,17 +37,25 @@ concurrency:
jobs:
beam_PreCommit_Go:
+ name: beam_PreCommit_Go (Run Go PreCommit)
+ runs-on: [self-hosted, ubuntu-20.04, main]
if: |
github.event_name == 'push' ||
github.event_name == 'pull_request_target' ||
github.event_name == 'schedule' ||
+ github.event_name == 'workflow_dispatch' ||
github.event.comment.body == 'Run Go PreCommit'
- runs-on: [self-hosted, ubuntu-20.04, main]
- name: beam_PreCommit_Go (Run Go PreCommit)
- steps:
- - uses: actions/checkout@v3
+ steps:
+ - name: Check out repository code
Review Comment:
Hm, what if we did something like:
```
steps:
- uses: actions/checkout@v3
- uses: ./github/actions/setup-action
```
Where setup-action is an action that (1) checks out the correct ref (we can
do this from bash) and (2) calls the rerun action.
Its technically a _little_ less efficient since we're doing 2 checkouts, but
we're still only doing one clone and the repo isn't huge, so it should be
negligible, and it simplifies the dev workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
