jon-esperanza commented on code in PR #27619:
URL: https://github.com/apache/beam/pull/27619#discussion_r1281389105
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -710,7 +710,7 @@ public static Row toBeamRow(Schema rowSchema, TableSchema
bqSchema, TableRow jso
(!innerTypeIsMap && v instanceof Map)
? ((Map<String, Object>) v).get("v")
: v)
- .map(v -> toBeamValue(fieldType.getCollectionElementType(), v))
+ .map(v -> toBeamRowFieldValue(Field.of("v",
fieldType.getCollectionElementType()), v))
Review Comment:
made the changes, please let me know if the commits should be more atomic
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -710,7 +710,7 @@ public static Row toBeamRow(Schema rowSchema, TableSchema
bqSchema, TableRow jso
(!innerTypeIsMap && v instanceof Map)
? ((Map<String, Object>) v).get("v")
: v)
- .map(v -> toBeamValue(fieldType.getCollectionElementType(), v))
+ .map(v -> toBeamRowFieldValue(Field.of("v",
fieldType.getCollectionElementType()), v))
Review Comment:
@Abacn I made the changes, please let me know if the commits should be more
atomic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
