tonytanger commented on code in PR #27755:
URL: https://github.com/apache/beam/pull/27755#discussion_r1283377400
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/reconciler/PartitionReconciler.java:
##########
@@ -100,6 +101,7 @@ public PartitionReconciler(MetadataTableDao
metadataTableDao, ChangeStreamMetric
* @param missingPartitions partitions not being streamed.
*/
public void addMissingPartitions(List<ByteStringRange> missingPartitions) {
+ hasAddedMissingPartitions = true;
Review Comment:
It should not be necessary to reset the flag. Though there's no downside to
resetting it.
The purpose of this flag is to ensure we don't call
`getPartitionsToReconcile` before it. If we do call `getPartitionsToReconcile`
before `addMissingPartitions` we run into the problem of We only call
`getPartitionsToReconcile` once per run and the entire `PartitionReconciler` is
reset at the start of every run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
