reuvenlax commented on code in PR #27835:
URL: https://github.com/apache/beam/pull/27835#discussion_r1283620034
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Group.java:
##########
@@ -1033,6 +1037,9 @@ static <InputT> CombineFieldsByFields<InputT> of(
.setSchemaAggregateFn(schemaAggregateFn)
.setKeyField(keyField)
.setValueField(valueField)
+ .setFewKeys(
+ true) // We are often selecting only certain fields, so combiner
lifting usually
Review Comment:
Yes, however there is a workaround (call withPrecombining(false)). IMO we
should document this in the Beam release notes along with the workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
