boyuanzz commented on a change in pull request #12430: URL: https://github.com/apache/beam/pull/12430#discussion_r465234180
########## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ########## @@ -1029,7 +1040,27 @@ public double getProgress() { private Progress getProgress() { synchronized (splitLock) { if (currentTracker instanceof RestrictionTracker.HasProgress) { - return ((HasProgress) currentTracker).getProgress(); + Progress progress = ((HasProgress) currentTracker).getProgress(); + double totalWork = progress.getWorkCompleted() + progress.getWorkRemaining(); + double completed = + totalWork * currentWindowIterator.previousIndex() + progress.getWorkCompleted(); + double remaining = + totalWork * (currentElement.getWindows().size() - currentWindowIterator.nextIndex()) + + progress.getWorkRemaining(); + return Progress.from(completed, remaining); + } + } + return null; + } + + private Progress getProgressFromWindowObservingTruncate(double elementCompleted) { + synchronized (splitLock) { + if (currentWindowIterator != null) { Review comment: I was hesitated to do so since I'm not sure whether the progress from Truncate is used anywhere unless it's used for runner side split decision. Then there is another question, should the progress from Truncate be used for split decision? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org