bvolpato commented on PR #27867: URL: https://github.com/apache/beam/pull/27867#issuecomment-1669464799
@scwhittle This was the intention here, to make MemoryMonitor in the FnHarness to reach `GCThrashingPercentagePerPeriod` as there was a regression on v2 that was ignoring and simply assuming 50.0: https://github.com/apache/beam/pull/27850 The problem is that it could break usage (there shouldn't be a lot, but still) of `setGCThrashingPercentagePerPeriod` when trying to access it through `DataflowPipelineDebugOptions`, so I wanted to make it more visible (SdkHarnessOptions seemed like a good fit). Good point, I think exporting to another options class makes sense. By MemoryManagerOptions you mean MemoryMonitorOptions to match the current class that handles the logic? Or prefer to call it a manager? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
