lostluck commented on pull request #12426: URL: https://github.com/apache/beam/pull/12426#issuecomment-668851393
Are we going to use this as a basis for a stand alone "beam:coder:map:v1" urn type as well? As it stands I'll be changing Go to use this encoding for map types by default anyway. Though I believe we don't have the equivalent "beam:coder:optional/nullable" component wrapper urn to handle the other half of this PR. This comes up as the following: In the event users are serializing raw maps or iterables with pointer components, the Go SDK will likely default to the nullable interpretation. This comes into play with proto element types which in Go are defaulted to pointers to structs. (However, this is probably a non-issue if the proto type is decomposed into a schema instead.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
