ryantam626 opened a new pull request, #27924:
URL: https://github.com/apache/beam/pull/27924
In the original snippet, we create two instances of `Timestamp(micros=s)`,
the later is rather short
lived as we immediately use the `__add__` dunder
method to create a brand new instance of `Timestamp`.
The change in this commit is to remove the construction of this short lived
`Timestamp` and reuse the one already constructed for the `start` argument of
`IntervalWindow`.
The speed gain of this change depends on the specification of the
`SlidingWindows`. I have a pipeline that is relatively simple and with GCP's
profiler in Dataflow, it revealed about ~2.5% of wall time is wasted in
constructing this short lived `Timestamp`.
Given that `__add__` doesn't alter the `Timestamp` object inplace (and
unlikely to be changed to that behaviour), I think this is a safe change.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
**This is just a oneliner change so I didn't bother, let me know if I should
do any of the below.**
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
