robertwb commented on code in PR #27939:
URL: https://github.com/apache/beam/pull/27939#discussion_r1289149574
##########
sdks/python/apache_beam/ml/transforms/base.py:
##########
@@ -134,7 +134,7 @@ def __init__(
themselves.
Args:
- artifact_location: A storage location for artifacts resulting from
+ write_artifact_location: A storage location for artifacts resulting from
Review Comment:
Maybe add a note that this will overwrite any other artifacts in this
location, and distinct artifact locations should be used for distinct ML
transforms?
##########
sdks/python/apache_beam/ml/transforms/base.py:
##########
@@ -134,7 +134,7 @@ def __init__(
themselves.
Args:
- artifact_location: A storage location for artifacts resulting from
+ write_artifact_location: A storage location for artifacts resulting from
Review Comment:
Maybe mention that this should be a directory, and that it will be created
if it does not already exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
