reuvenlax commented on code in PR #27866:
URL: https://github.com/apache/beam/pull/27866#discussion_r1290192019
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProtoTest.java:
##########
@@ -559,55 +703,218 @@ public class TableRowToStorageApiProtoTest {
.setLabel(Label.LABEL_OPTIONAL)
.build())
.build();
+
+ private static final com.google.cloud.bigquery.storage.v1.TableSchema
+ BASE_TABLE_NO_F_PROTO_SCHEMA =
Review Comment:
Because TableRow is a strange class. It can be used either as a map
(row.get("field")) or as a list of of fields (row.getF()). However TableRow
also interprets row.get("f") as an alias for row.getF(), which means that if
you have a field named "f" attempting to use the object as a map will fail.
This has caused bugs in the past when users had a real field named "f".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
