bvolpato commented on code in PR #27932:
URL: https://github.com/apache/beam/pull/27932#discussion_r1290527781
##########
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptionsTest.java:
##########
@@ -242,6 +244,7 @@ public void testDefaultGcpRegionFromEnvironment() {
when(DefaultGcpRegionFactory.getRegionFromEnvironment()).thenReturn("us-west1");
DataflowPipelineOptions options =
PipelineOptionsFactory.as(DataflowPipelineOptions.class);
assertEquals("us-west1", options.getRegion());
+ assertEquals("us-west1-" + Dataflow.DEFAULT_SERVICE_PATH,
options.getDataflowEndpoint());
Review Comment:
`Dataflow.DEFAULT_SERVICE_PATH` seems to be empty (`""`). Is that what we
want to pass as DataflowEndpoint?
`us-west1-`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
