m-trieu commented on code in PR #27767:
URL: https://github.com/apache/beam/pull/27767#discussion_r1291778054
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/AbstractWindmillStream.java:
##########
@@ -133,13 +130,13 @@ private static long debugDuration(long nowMs, long
startMs) {
protected abstract boolean hasPendingRequests();
/**
- * Called when the stream is throttled due to resource exhausted errors.
Will be called for each
- * resource exhausted error not just the first. onResponse() must stop
throttling on receipt of
- * the first good message.
+ * Called when the client side stream is throttled due to resource exhausted
errors. Will be
+ * called for each resource exhausted error not just the first. onResponse()
must stop throttling
+ * on receipt of the first good message.
*/
protected abstract void startThrottleTimer();
- private StreamObserver<RequestT> requestObserver() {
+ protected StreamObserver<RequestT> requestObserver() {
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
