Abacn commented on code in PR #27805: URL: https://github.com/apache/beam/pull/27805#discussion_r1293732455
########## .test-infra/jenkins/README.md: ########## @@ -162,7 +162,7 @@ Beam Jenkins overview page: [link](https://ci-beam.apache.org/) | beam_PostCommit_Python_VR_Spark | [cron](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/), [phrase](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/) | `Run Python Spark ValidatesRunner` | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark) | | beam_PostCommit_Python_Xlang_Gcp_Direct | [cron](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Direct/), [phrase](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Direct_PR/) | `Run Python_Xlang_Gcp_Direct PostCommit` | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Direct/) | | beam_PostCommit_Python_Xlang_Gcp_Dataflow | [cron](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Dataflow/), [phrase](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Dataflow_PR/) | `Run Python_Xlang_Gcp_Dataflow PostCommit` | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_Gcp_Dataflow/) | -| beam_PostCommit_Python38 | [cron](https://ci-beam.apache.org/job/beam_PostCommit_Python38), [phrase](https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/) | `Run Python 3.8 PostCommit` | [](https://ci-beam.apache.org/job/beam_PostCommit_Python38) | +| beam_PostCommit_Python_Xlang_IO_Dataflow | [cron](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_IO_Dataflow/), [phrase](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_IO_Dataflow_PR/) | `Run Python_Xlang_IO_Dataflow PostCommit` | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_Xlang_IO_Dataflow/)<br/>| beam_PostCommit_Python38 | [cron](https://ci-beam.apache.org/job/beam_PostCommit_Python38), [phrase](https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/) | `Run Python 3.8 PostCommit` | [](https://ci-beam.apache.org/job/beam_PostCommit_Python38) | Review Comment: redundant `<br/>`? ########## buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy: ########## @@ -2522,6 +2526,9 @@ class BeamModulePlugin implements Plugin<Project> { project.exec { environment "EXPANSION_JAR", expansionJar environment "EXPANSION_PORT", javaExpansionPort + if (config.additionalArgs.containsKey("KAFKA_BOOTSTRAP_SERVER")) { + environment "BOOTSTRAP_SERVER", config.additionalArgs.get("KAFKA_BOOTSTRAP_SERVER") Review Comment: Consider use the same naming (`BOOTSTRAP_SERVER` -> `KAFKA_BOOTSTRAP_SERVER`)? And could`config.additionalArgs` be generalized? e.g., naming this variable as config.additionalEnvs, and for all keys, set the corresponding environment variable accordingly; or actually these environment variables are effective once set so its can be set in gradle file directly and does not need to touch BeamModulePlugin? Or there could be a better way. In any case the purpose is that keep BeamModulePlugin logic generic so Kafka things/namings does not explicitly appear here ########## .test-infra/jenkins/job_PostCommit_Python_CrossLanguage_IO_Dataflow.groovy: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + +import CommonJobProperties as commonJobProperties Review Comment: We now suggest new test suites to be added as github actions, which can be followup. For now gets test running suffices. ########## sdks/python/test-suites/xlang/build.gradle: ########## @@ -58,5 +58,19 @@ def gcpXlangCommon = new CrossLanguageTaskCommon().tap { } xlangTasks.add(gcpXlangCommon) +def ioExpansionProject = project.project(':sdks:java:io:expansion-service') + +def ioXlangCommon = new CrossLanguageTaskCommon().tap { + name = "ioCrossLanguage" + expansionProjectPath = ioExpansionProject.getPath() + collectMarker = "uses_io_expansion_service" + startJobServer = setupTask + cleanupJobServer = cleanupTask + //Temporary hardcoding while we await GMK (google managed kafka) TODO johnjcasey + //See .test-infra/kafka/bitnami/README.md for setup instructions + additionalArgs = ["KAFKA_BOOTSTRAP_SERVER":"10.128.0.40:9094,10.128.0.28:9094,10.128.0.165:9094"] Review Comment: consider making this configurable, could use sth like `project.findProperty('kafkaBootstrapServer') ?: "10.128.0.40:9094,10.128.0.28:9094,10.128.0.165:9094"`, or alternatively, set this in test CI (jenkins groovy file or github action yml) so we do not need to add TODO here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
