ahmedabu98 commented on code in PR #27578: URL: https://github.com/apache/beam/pull/27578#discussion_r1293758988
########## .test-infra/jenkins/job_PostCommit_TransformService_Direct.groovy: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties +import PostcommitJobBuilder + +import static PythonTestProperties.TRANSFORM_SERVICE_PYTHON_VERSION + +// This job runs multi-language pipelines using the Docker Compose based TransformService against the Direct runner. +// Collects tests with the @pytest.mark.uses_transform_service decorator +PostcommitJobBuilder.postCommitJob('beam_PostCommit_TransformService_Direct', + 'Run TransformService_Direct PostCommit', 'Direct TransformService Tests', this) { + description('Runs the TransformService suite on the Direct runner.') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 120) + + // Publish all test results to Jenkins + publishers { + archiveJunit('**/pytest*.xml') + } + + // Gradle goals for this job. + steps { + shell("echo \"*** RUN TRANSFORM SERVICE DIRECT USING PYTHON TRANSFORM_SERVICE_PYTHON_VERSION ***\"") + gradle { + rootBuildScriptDir(commonJobProperties.checkoutDir) + tasks(':sdks:python:test-suites:direct:xlang:transformServicePythonUsingJava') + commonJobProperties.setGradleSwitches(delegate) + switches '-PcompileAndRunTestsWithJava11' + switches "-Pjava11Home=${commonJobProperties.JAVA_11_HOME}" + } Review Comment: FYI tests can run faster if we use Python wheels @Abacn helped me with that [here](https://github.com/apache/beam/pull/26491#issuecomment-1532321548) ########## .test-infra/jenkins/job_PostCommit_TransformService_Direct.groovy: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as commonJobProperties +import PostcommitJobBuilder + +import static PythonTestProperties.TRANSFORM_SERVICE_PYTHON_VERSION + +// This job runs multi-language pipelines using the Docker Compose based TransformService against the Direct runner. +// Collects tests with the @pytest.mark.uses_transform_service decorator +PostcommitJobBuilder.postCommitJob('beam_PostCommit_TransformService_Direct', + 'Run TransformService_Direct PostCommit', 'Direct TransformService Tests', this) { + description('Runs the TransformService suite on the Direct runner.') + + // Set common parameters. + commonJobProperties.setTopLevelMainJobProperties(delegate, 'master', 120) + + // Publish all test results to Jenkins + publishers { + archiveJunit('**/pytest*.xml') + } + + // Gradle goals for this job. + steps { + shell("echo \"*** RUN TRANSFORM SERVICE DIRECT USING PYTHON TRANSFORM_SERVICE_PYTHON_VERSION ***\"") Review Comment: Did you mean to embed the value into this string? ########## sdks/python/apache_beam/io/gcp/bigtableio_it_test.py: ########## @@ -50,6 +50,7 @@ @pytest.mark.uses_gcp_java_expansion_service [email protected]_transform_service Review Comment: I may be missing something but how does this test suite make sure to build the necessary jars before running? For example in this test we need `:sdks:java:io:google-cloud-platform:expansion-service` ########## sdks/python/test-suites/direct/xlang/build.gradle: ########## @@ -67,3 +69,20 @@ createCrossLanguageValidatesRunnerTask( "--endpoint localhost:${jobPort}", ], ) + +createTransformServiceTask( Review Comment: Can we add a comment here that these tests are run with Py38? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
