Abacn commented on code in PR #28010: URL: https://github.com/apache/beam/pull/28010#discussion_r1294873486
########## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/logging/DataflowWorkerLoggingInitializer.java: ########## @@ -35,9 +35,12 @@ import java.util.logging.LogManager; import java.util.logging.Logger; import org.apache.beam.runners.dataflow.options.DataflowWorkerLoggingOptions; +import org.apache.beam.sdk.options.SdkHarnessOptions; Review Comment: Although legacy runner does not involve Sdk Harness, this option is used here. It may sounds weird. This was discussed before: https://github.com/apache/beam/pull/23635#discussion_r998897966 but we chose to keep the current naming to avoid refactoring that would affecting users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
