reuvenlax commented on code in PR #27891:
URL: https://github.com/apache/beam/pull/27891#discussion_r1294991153
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java:
##########
@@ -936,8 +937,9 @@ private <K, V> void groupByKeyHelper(
&& windowingStrategy.getWindowFn().assignsToOneWindow();
if (isStreaming) {
allowCombinerLifting &= transform.fewKeys();
- // TODO: Allow combiner lifting on the non-default trigger, as
appropriate.
- allowCombinerLifting &= (windowingStrategy.getTrigger()
instanceof DefaultTrigger);
+ // We don't currently have a good way to safely lift combiners
in the face of count triggers, as we will
+ // lose track of how many elements have been combined.
+ allowCombinerLifting &=
!containsCountTrigger(windowingStrategy.getTrigger());
Review Comment:
This affects Dataflow only I think, so I don't think dev@ is the correct
avenue here. Ideally Dataflow would make this decision in its backend, but not
sure how easy that would be to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
