lostluck commented on PR #27842: URL: https://github.com/apache/beam/pull/27842#issuecomment-1679459664
I have validated the change with a little guidance from @damondouglas in testing live changes on the Java SDK. I did have a bug in my write error handling causing the container to hard fail 100% of the time. It's concerning that I couldn't find any Gradle tests that quickly smoke check the Java Portable Containers. I'm a little surprised that there wasn't any against the Python Portable runner that rely on containers. (Or if there is, it's not obvious and I couldn't find it among our Actions or Jenkins tasks, or gradle commands). I'll eventually be getting such a suite up for Prism however when I get to seeing other SDKs run on it. Hopefully I can get back to that soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
