jrmccluskey commented on code in PR #27995:
URL: https://github.com/apache/beam/pull/27995#discussion_r1296021870
##########
sdks/python/apache_beam/utils/multi_process_shared.py:
##########
@@ -82,7 +82,23 @@ def singletonProxy_release(self):
def __getattr__(self, name):
if not self._SingletonProxy_valid:
raise RuntimeError('Entry was released.')
- return getattr(self._SingletonProxy_entry.obj, name)
+ try:
+ return getattr(self._SingletonProxy_entry.obj, name)
+ except AttributeError as e:
+ # Swallow AttributeError exceptions so that they are ignored when
+ # calculating public functions. These can occur if __getattr__ is
+ # overriden, for example to only support some platforms. This will mean
+ # that these functions will be silently unavailable to the
+ # MultiProcessShared object, leading to worse errors when someone tries
+ # to use them, but it will keep them from breaking the whole object for
+ # functions which are unusable anyways.
+ logging.info(
Review Comment:
Nit: this could be called out at warning instead of at info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
