Abacn commented on PR #27971: URL: https://github.com/apache/beam/pull/27971#issuecomment-1680753790
Thanks for solving this long-standing issue! The PR looks pretty solid to me. One concern is that could it be substantial breaking change if changing the signature from AvroSource<T> to AvroSource<AvroT, T>. As Java Generic does not support default (e.g. class A<T, V=T>), one solution for less singature change is to define AvroSource<T> extends CodableAvroSource<T, T>; or make CodableAvroSource<AvroT, T> extends AvroSource<T> (did a little bit search: https://www.google.com/search?q=codable&oq=codable&aqs=chrome..69i57j0i512l6j69i64.1163j0j4&sourceid=chrome&ie=UTF-8) The goal is make the change needed for the code base smaller / which also means the possibility user needs to rewrite their pipeline smaller -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
