tvalentyn commented on code in PR #28033:
URL: https://github.com/apache/beam/pull/28033#discussion_r1296323781
##########
sdks/python/container/build.gradle:
##########
@@ -42,8 +42,33 @@ tasks.register("buildAll") {
dependsOn ':sdks:python:container:py311:docker'
}
+for(int i=8; i<=11; ++i) {
+ String cur = "3" + i
+ String prev = "3" + (i-1)
+ tasks.register("push" + cur) {
+ if (cur != "38") {
Review Comment:
we should try to hardcode python versions in as few pieces as possible.
Ideally, we should have lowest supported and highest supported constant,
similar to
https://github.com/apache/beam/blob/42ca3bf598e70e3baa550859de1d2ca6712bd8f6/.test-infra/jenkins/PythonTestProperties.groovy#L31
. Maybe in top level settings.gradle. Other place that would benefit from
this:
https://github.com/apache/beam/blob/master/sdks/python/test-suites/gradle.properties
. If that's too much hassle right now, consider at least not adding
lowest/highest constant in this file, so that we programmatically evaluate line
49.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
