tvalentyn commented on code in PR #28036:
URL: https://github.com/apache/beam/pull/28036#discussion_r1296433672
##########
sdks/python/container/Dockerfile:
##########
@@ -80,6 +80,11 @@ RUN \
# Remove pip cache.
rm -rf /root/.cache/pip
+# Required for using Beam Python SDK on ARM machines.
+RUN if [ "${TARGETARCH}" = "arm64" ] ; then \
+ apt-get install libgeos-dev ; \
Review Comment:
i would suggest to move these statements to line 42 (keeping the statements
inside one RUN command). note that apt temp files are cleared in line 44, and
this command might require a prior call to `apt update`.
Also, did you run validatesconainerarm tests to verify this change ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
