lostluck commented on code in PR #28083:
URL: https://github.com/apache/beam/pull/28083#discussion_r1301944528


##########
sdks/go/pkg/beam/runners/prism/internal/execute.go:
##########
@@ -47,7 +47,8 @@ func RunPipeline(j *jobservices.Job) {
        // environments, and start up docker containers, but
        // here, we only want and need the go one, operating
        // in loopback mode.
-       env := "go"
+       envs := j.Pipeline.GetComponents().GetEnvironments()
+       env, _ := getOnlyPair(envs)

Review Comment:
   Added a clarification, and normal job failed/error propagation instead of 
panic explosion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to