damccorm commented on code in PR #27620: URL: https://github.com/apache/beam/pull/27620#discussion_r1303137734
########## sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py: ########## @@ -55,7 +55,7 @@ def _publish_metrics(pipeline, metric_value, metrics_table, metric_name): )]) [email protected]_tft +# @pytest.mark.uses_tft Review Comment: Can we just get rid of this comment (and the pytest import comment) ########## sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py: ########## @@ -55,7 +55,7 @@ def _publish_metrics(pipeline, metric_value, metrics_table, metric_name): )]) [email protected]_tft +# @pytest.mark.uses_tft Review Comment: Wait, don't we actually need this for https://github.com/apache/beam/blob/6cae195d4ab62a5b433f8781328ddc3f57b9c74f/sdks/python/test-suites/dataflow/common.gradle#L454 ########## sdks/python/apache_beam/examples/ml_transform/vocab_tfidf_processing.py: ########## @@ -130,7 +130,7 @@ def preprocess_data( data_pcoll = ( data_pcoll | beam.ParDo(MapTFIDFScoreToVocab(artifact_location))) - _ = (data_pcoll | beam.io.WriteToText(output_dir)) + # _ = (data_pcoll | beam.io.WriteToText(output_dir)) Review Comment: Can we get rid of this comment? ########## sdks/python/apache_beam/examples/ml_transform/vocab_tfidf_processing.py: ########## @@ -130,7 +130,7 @@ def preprocess_data( data_pcoll = ( data_pcoll | beam.ParDo(MapTFIDFScoreToVocab(artifact_location))) - _ = (data_pcoll | beam.io.WriteToText(output_dir)) + # _ = (data_pcoll | beam.io.WriteToText(output_dir)) Review Comment: Actually, is there a reason we're not writing anymore? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
