ahmedabu98 commented on code in PR #28124:
URL: https://github.com/apache/beam/pull/28124#discussion_r1303569885
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3254,9 +3270,12 @@ && getStorageApiTriggeringFrequency(bqOptions) != null) {
if (getRowMutationInformationFn() != null) {
checkArgument(getMethod() == Method.STORAGE_API_AT_LEAST_ONCE);
checkArgument(
- getCreateDisposition() == CreateDisposition.CREATE_NEVER,
- "CREATE_IF_NEEDED is not supported when applying row updates.
Tables must be precreated "
- + "with a primary key specified.");
+ getCreateDisposition() == CreateDisposition.CREATE_NEVER ||
getPrimaryKey() != null,
+ "If specifying CREATE_IF_NEEDED along with row updates, a primary
key needs to be specified");
+ }
+ if (getPrimaryKey() != null) {
+ checkArgument(
+ getMethod() != Method.FILE_LOADS, "Primary key not supported when
using FILE_LOADS");
Review Comment:
Can we also add `STREAMING_INSERTS` to this check?
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkRowUpdateIT.java:
##########
@@ -130,16 +101,19 @@ public void testCdc() throws Exception {
new TableRow().set("key1", "foo4").set("key2",
"bar4").set("value", "1"),
RowMutationInformation.of(RowMutationInformation.MutationType.DELETE, 1)));
- String tableSpec = createTable(tableSchema, Lists.newArrayList("key1",
"key2"));
+ List<String> primaryKey = Lists.newArrayList("key1", "key2");
+ String tableSpec = getTablespec();
Pipeline p = Pipeline.create();
p.apply("Create rows", Create.of(items))
.apply(
"Apply updates",
BigQueryIO.applyRowMutations()
.to(tableSpec)
.withSchema(tableSchema)
+ .withPrimaryKey(primaryKey)
+ .withClustering(new Clustering().setFields(primaryKey))
Review Comment:
nit: is there a need to set clustering in this test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
