AnandInguva commented on code in PR #28159:
URL: https://github.com/apache/beam/pull/28159#discussion_r1306359601
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1423,15 +1423,27 @@ def _check_fn_use_yield_and_return(fn):
source_code = _get_function_body_without_inners(fn)
has_yield = False
has_return = False
+ return_none_warning = "No iterator is returned by " \
+ "the process method in DoFn."
Review Comment:
```suggestion
return_none_warning = ("No iterator is returned by "
"the process method in DoFn.")
```
##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1423,15 +1423,27 @@ def _check_fn_use_yield_and_return(fn):
source_code = _get_function_body_without_inners(fn)
has_yield = False
has_return = False
+ return_none_warning = "No iterator is returned by " \
+ "the process method in DoFn."
Review Comment:
This warning could be meaningful if it can mention the faulty DoFn. Can we
add the name of the DoFn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
