jto commented on code in PR #28045:
URL: https://github.com/apache/beam/pull/28045#discussion_r1307336390
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/SourceInputFormat.java:
##########
@@ -108,12 +110,27 @@ public float getAverageRecordWidth() {
return null;
}
+ private long getDesiredSizeBytes(int numSplits) throws Exception {
+ long totalSize = initialSource.getEstimatedSizeBytes(options);
+ long defaultSplitSize = totalSize / numSplits;
+ if (initialSource instanceof FileBasedSource) {
+ long maxSplitSize =
options.as(FlinkPipelineOptions.class).getFileInputSplitMaxSizeBytes();
Review Comment:
Sounds reasonable. I'll make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
