tvalentyn commented on code in PR #27536:
URL: https://github.com/apache/beam/pull/27536#discussion_r1312036631
##########
.github/workflows/build_wheels.yml:
##########
@@ -269,7 +269,7 @@ jobs:
# TODO: https://github.com/apache/beam/issues/23048
CIBW_SKIP: "*-musllinux_*"
CIBW_ENVIRONMENT: "SETUPTOOLS_USE_DISTUTILS=stdlib"
- CIBW_BEFORE_BUILD: pip install cython==0.29.36 numpy && pip install
--upgrade setuptools
+ CIBW_BEFORE_BUILD: pip install cython==3.0.0 numpy && pip install
--upgrade setuptools
Review Comment:
Makes sense.
https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#exception-values-and-noexcept
explains the change and rationale, and also calls out the performance pitfall
for `nogil` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
