mkuthan opened a new issue, #28282:
URL: https://github.com/apache/beam/issues/28282

   ### What happened?
   
   For unbounded collections and FileLoads writing method default value for 
maxRetryJobs is 1000. It delays step failure if the error is permanent, for 
example if TableRow contains timestamp field with invalid value (out of 
accepted range).
   
   I found the following comment in the code:
   
   ```
   // When running in streaming (unbounded mode) we want to retry failed load 
jobs
   // indefinitely. Failing the bundle is expensive, so we set a fairly high 
limit on retries.
   if (IsBounded.UNBOUNDED.equals(input.isBounded())) {
     batchLoads.setMaxRetryJobs(getMaxRetryJobs());
   }
   
   public static <T> Write<T> write() {
       return new AutoValue_BigQueryIO_Write.Builder<T>()
         ...
         .setMaxRetryJobs(1000)
         ...
         .build()
   ```
   
   I would expect:
   * no retries for persistent errors
   * a few retries for transient errors but much less than 1000
   
   In addition the 
[Documentation](https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html#withMaxRetryJobs-int-)
 is far for complete:
   
   * No information that settings is only applicable for FileLoads
   * No information about behaviour if maxRetryJobs is not specified
   
   ### Issue Priority
   
   Priority: 2 (default / most bugs should be filed as P2)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [X] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [ ] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to