gabrywu commented on PR #28253: URL: https://github.com/apache/beam/pull/28253#issuecomment-1703999204
> LGTM. It's totally reasonable to add the method as they corresponding the dofn lifecycle methods. Probably we should add them at the beginning. > > * One thing to note when implementing youe own BeamSqlSeekableTable. startBundle can be called many times, so if initializing a connection in it, it's good to use a connection pool otherwise there could be too much connection - a common issue seen in Beam IO implementation > > also, its nice to have a test checking dofn lifecycle is effective with BeamSqlSeekableTable methods. thanks very much. I will add initialized flag to startBundle in our own BeamSqlSeekableTable to avoid too much connection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
