Abacn commented on code in PR #28272:
URL: https://github.com/apache/beam/pull/28272#discussion_r1316106171
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java:
##########
@@ -206,7 +206,15 @@ private PendingJobData startWriteRename(
// Make sure each destination table gets a unique job id.
String jobIdPrefix =
BigQueryResourceNaming.createJobIdWithDestination(
- c.sideInput(jobIdToken), finalTableDestination, -1,
c.pane().getIndex());
+ c.sideInput(jobIdToken), finalTableDestination, -1);
+
+ if (isFirstPane) {
Review Comment:
this is another code path relying on pane info. Checked that upstream
transform has a GBK and no ReShuffle in between:
https://github.com/apache/beam/blob/0ed4c78a799cf5a6cc6a0b40b23ca498096769c5/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java#L404C5-L404C5
so this one should be fine. Nevertheless it's good to add logging to monitor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
