ibzib commented on a change in pull request #12461:
URL: https://github.com/apache/beam/pull/12461#discussion_r466615046
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslUdfUdafTest.java
##########
@@ -101,6 +104,21 @@ public void testJodaTimeUdfUdaf() throws Exception {
pipeline.run().waitUntilFinish();
}
+ @Test
+ public void testListUdf() throws Exception {
Review comment:
The tests LGTM, but we should separate the two blocks into separate
`@Test` methods. That way we can easily tell if one case fails but the other
succeeds. And it keeps the tests smaller and easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
