damccorm commented on code in PR #28116:
URL: https://github.com/apache/beam/pull/28116#discussion_r1319811100
##########
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/resources/ClasspathScanningResourcesDetectorTest.java:
##########
@@ -120,7 +120,7 @@ public void
shouldDetectClassPathResourceFromJavaClassPathEnvVariable() throws I
@Test
public void shouldNotDetectClassPathResourceThatIsNotAFile() throws
Exception {
- String url = "http://www.google.com/all-the-secrets.jar";;
+ String url = "http://www.example.com/all-the-secrets.jar";;
Review Comment:
Why did we need this change? Was the test failing without the change or was
it just to make it more generic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
