robertwb commented on a change in pull request #12352:
URL: https://github.com/apache/beam/pull/12352#discussion_r466727543
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -188,7 +188,8 @@ def __init__(self,
self.name_context.step_name,
0,
next(iter(itervalues(consumers))),
- self.windowed_coder)
+ self.windowed_coder,
+ self)
Review comment:
When I said "big" I meant in terms of surface area. (You're right that
there's no performance concern here.) E.g. it's easier to reason about the code
when we see that the callee is interested in the type hints rather than the
whole operation.
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -520,10 +520,26 @@ def run(self, test_runner_api='AUTO'):
self._options,
allow_proto_holders=True).run(False)
+ if (self._options.view_as(TypeOptions).runtime_type_check and
+ self._options.view_as(TypeOptions).performance_runtime_type_check):
+ raise RuntimeError(
Review comment:
I think eventually we'll want to consolidate the two. I suppose we can
prohibit setting both if we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
