udim commented on pull request #12242: URL: https://github.com/apache/beam/pull/12242#issuecomment-670239967
> Sorry I didn't have a chance to look at this sooner. > > Since this is a purely local change, I would suggest rather than adding all this infrastructure simply creating a variant of (or even adding an option to) > > https://github.com/apache/beam/blob/master/sdks/python/apache_beam/tools/map_fn_microbenchmark.py > > which enables the two runtime type checking. This'll be much cleaner numbers, and a lot faster turn-around time. (It'd probably be valuable to run this before and after your changes even with typechecking turned off to ensure you're not adding overhead in that case too.) My goal in suggesting this framework was to gather historical numbers, and to test for performance regressions in future PRs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
