Abacn commented on code in PR #28274:
URL: https://github.com/apache/beam/pull/28274#discussion_r1325013235
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -689,7 +696,7 @@ public void setSchema(org.apache.avro.Schema schema) {
@Override
public T read(T reuse, Decoder in) throws IOException {
GenericRecord record = (GenericRecord) this.reader.read(reuse, in);
- return parseFn.apply(new SchemaAndRecord(record,
this.tableSchema.get()));
+ return parseFn.apply(new SchemaAndRecord(record, this.tableSchema));
Review Comment:
(answer myself) I think after the change of #22718, the supplier is not
needed, as it no longer involves preserving a TableSchema in
SerializableFunction. It is now a named static class GenericDatumTransformer
not implementing Serializable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
