Abacn commented on code in PR #28440:
URL: https://github.com/apache/beam/pull/28440#discussion_r1325076983


##########
.github/workflows/beam_PreCommit_Java.yml:
##########
@@ -172,10 +173,11 @@ jobs:
             -PdisableSpotlessCheck=true \
             -PdisableCheckStyle=true \
       - name: Upload test report
+        if: failure()

Review Comment:
   There will be a third party workflow generating junit reports: #28075 to be 
added to all tests. This is available as a complement if one ones to see raw 
reports so failure() should suffice. I did not investigate how big the artifact 
could be so I would suggest roll out to failure() first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to