apilloud commented on a change in pull request #12483:
URL: https://github.com/apache/beam/pull/12483#discussion_r466754168
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java
##########
@@ -147,4 +165,35 @@ public int hashCode() {
return super.hashCode();
}
}
+
+ private static class NamedDynamicParam extends SqlDynamicParam {
Review comment:
nit: AutoValue might save you some boilerplate (equals, hashcode) in
this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
