liferoad commented on code in PR #28475:
URL: https://github.com/apache/beam/pull/28475#discussion_r1327668893
##########
sdks/python/apache_beam/internal/gcp/auth.py:
##########
@@ -159,12 +159,19 @@ def _get_service_credentials(pipeline_options):
'Credentials.')
return credentials
except Exception as e:
- _LOGGER.warning(
+ _LOGGER.error(
Review Comment:
I am not sure we need to change this to error since connecting anonymously
is allowed. And can we also make the message much clearer? e.g, Unable to find
default credentials to use: %s\n, Connecting anonymously. This is expected if
no credentials are required to access GCP resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
