hjtran opened a new pull request, #28489: URL: https://github.com/apache/beam/pull/28489
**Please** add a meaningful description for your change here ------------------------ Issue: ------ If somehow you have an annotation(s) on a `CombinePerKey` transform (e.g. because you subclass it and add annotations or a runner adds annotations), the annotations end up disappearing after getting translated by `lifted_stages`. Considerations: ---------------- I don't think it's super obvious what the correct behavior is here. It's a bit surprising the annotation disappears but it may also be surprising for someone who meant to signal some behavior for one transform to suddenly have it for the four resulting component transforms. I put up this PR in case it does make sense to propagate the annotations since for our use case it simplifies things a lot Context: -------- We're writing a runner and we'd like to be able to save the top level user labels that users assign to their transforms so we can nicely log which user transform is being run at every phase. The most obvious way to me to do this was to create some custom annotations and then search for them at phase execution time. I was surprised when the CPK annotations were missing. Open to other ways to do this though GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
