caneff commented on PR #28523: URL: https://github.com/apache/beam/pull/28523#issuecomment-1726669815
So the default in 2 changes to None, and None isnt valid so things break. I can make it so that populate defaults uses the copy_on_write for that setting like Pandas uses instead of just true? That is more in line as the same API. On Tue, Sep 19, 2023, 6:56 PM tvalentyn ***@***.***> wrote: > Are some tests failing on Pandas2 if we don't set it copy=True? > > I think I understand the idea of preserving the behavior but also > concerned since this will be a difference in defaults b/w Beam and Pandas. > > Also, we could call this out in > https://beam.apache.org/documentation/dsls/dataframes/differences-from-pandas/ > . > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/28523#issuecomment-1726648829>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABG4SHYCRPVXBGYR7OODLM3X3IPJRANCNFSM6AAAAAA46AGAKE> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
