damccorm commented on code in PR #28553:
URL: https://github.com/apache/beam/pull/28553#discussion_r1331876394
##########
sdks/typescript/package.json:
##########
@@ -36,7 +36,7 @@
},
"dependencies": {
"@google-cloud/pubsub": "^2.19.4",
- "@grpc/grpc-js": "^1.8.8",
+ "@grpc/grpc-js": "^1.4.6",
Review Comment:
Probably its actually the package-lock changes that fixed things.
Specifically, `"node_modules/@grpc/grpc-js"` went from `1.8.8` to `1.4.6`. But
that kinda just means you got lucky 😄 we should change this from `^1.4.6` to
`1.4.6` if we're sensitive to the version changing (or at least `~1.4.6` if we
don't care about the patch version changing). See https://devhints.io/semver
If we don't do that, the next time someone runs `npm install` (if for
example they change a different package), this is liable to change.
##########
sdks/typescript/package.json:
##########
@@ -36,7 +36,7 @@
},
"dependencies": {
"@google-cloud/pubsub": "^2.19.4",
- "@grpc/grpc-js": "^1.8.8",
+ "@grpc/grpc-js": "^1.4.6",
Review Comment:
Probably its actually the package-lock changes that fixed things.
Specifically, `"node_modules/@grpc/grpc-js"` went from `1.8.8` to `1.4.6`. But
that kinda just means you got lucky 😄 we should change this from `^1.4.6` to
`1.4.6` if we're sensitive to the version changing (or at least `~1.4.6` if we
don't care about the patch version changing). See https://devhints.io/semver
If we don't do that, the next time someone runs `npm install` (if for
example they change a different package), this is liable to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
