je-ik commented on PR #28567:
URL: https://github.com/apache/beam/pull/28567#issuecomment-1729155734
I don't think we can just skip the check. The fact that the check fails
implies there are still buffered data that have not been processed yet. We
need to either:
a) correctly flush and process the buffered data (which will clear the
hold), or
b) ensure that checkpoint is called before the final watermark
I have a suspicion that correct is only b), because otherwise, in case of
failure and restore from checkpoint after we flushed the data, we might break
the stable input contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
