apilloud commented on a change in pull request #12500:
URL: https://github.com/apache/beam/pull/12500#discussion_r467178896
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BeamSqlUnparseContext.java
##########
@@ -110,6 +111,26 @@ public SqlNode toSql(RexProgram program, RexNode rex) {
public void unparse(SqlWriter writer, int leftPrec, int rightPrec) {
writer.literal("DATETIME '" + timestampString.toString() + "'");
}
+
+ @Override
Review comment:
@ZijieSong946 This class is a good candidate for AutoValue to eliminate
this boilerplate.
(This got missed in #12348 because it was merged without a Jenkins run. cc:
@robinyqiu )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
