baeminbo commented on PR #28548: URL: https://github.com/apache/beam/pull/28548#issuecomment-1730908098
I put a comment `not owned` to the `reader` field in the class `UnboundedReaderIterator` in `WorkerCustomSources.java`. My first fix was simply to close the `reader` in `UnboundedReaderIterator#close()`. But, it had a bug to read the same data again from a reader in integration tests. To avoid this mistake again, I put the comment and additional check at `ResidualSource#getCheckpointMark()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
