Abacn commented on code in PR #28615:
URL: https://github.com/apache/beam/pull/28615#discussion_r1334504101
##########
.test-infra/metrics/sync/github/sync_workflows.py:
##########
@@ -134,13 +134,11 @@ def fetchWorkflowData():
workflows.append(workflowsPage)
for pageItem in workflows:
for item in pageItem:
- path =item['path']
- isPostCommit = re.search('(.*)postcommit(.*)',path)
- if isPostCommit:
- result = re.search('/(.*).yml', path)
- path =(result.group(1)) + ".yml"
- workflowObject = Workflow(item['id'],item['name'],path)
- WORKFLOWS_OBJECT_LIST.append(workflowObject)
+ path = item['path']
+ result = re.search('/(.*).yml', path)
+ path = (result.group(1)) + ".yml"
+ workflowObject = Workflow(item['id'],item['name'],path)
+ WORKFLOWS_OBJECT_LIST.append(workflowObject)
url = "https://api.github.com/repos/apache/beam/actions/workflows/";
queryOptions = { 'branch' : 'master', 'per_page' :
GH_WORKFLOWS_NUMBER_EXECUTIONS,
Review Comment:
If the trigger phrase does not match the workflow, it is skipped; if it
matches the workflow runs to end, so I expect it won't get cancelled
I would understand the workflows does not have scheduled run not in the
scope of "PostCommit" - and they are handful of them and we can either use
different filter (if workflow name does not match PreCommit or PostCommit) or
do not include them in postcommit dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
